Conversation
- @beforeeach로 기수와 appjamMode를 컨트롤하도록 명시
kyoooooong
reviewed
Mar 27, 2026
kyoooooong
left a comment
kyoooooong
left a comment
There was a problem hiding this comment.
너무 수고 많으셨습니다!! 🫡 만약 테스트가 조금 중요하다면, 테스트에서도 현재 기수가 아닌 유저에 대해서는 이벤트가 발행되지 않는 케이스가 있어도 좋을 것같아요! 하지만 테스트가 비중이 높지 않다면 없어도 좋을 것같습니다 👍
| ); | ||
|
|
||
| eventPublisher.raise(SoptampUserAllCacheSyncEvent.of(userId)); | ||
| this.raiseAllCacheSyncEvent(registeredUser); |
There was a problem hiding this comment.
아 이벤트를 바로 발행하는게 아니라 현재 기수일 때만 발행하도록 하신 건가요? 너무 좋습니다 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Related ScreenShot 📷
To Reviewers 📢