Conversation
kyoooooong
reviewed
Mar 27, 2026
| val completedStampList = stampRepository.findAllByUserId(userId); | ||
| val missionList = missionRepository.findAllByDisplay(true); | ||
| val completedStampList = stampRepository.findAllByUserId(userId);; | ||
| val missionList = missionRepository.findAllByDisplayOrderByLevelAscTitleAsc(true); |
There was a problem hiding this comment.
오 정렬을 stream에서 하지 않고 repository 조회 메서드로 옮기셨군요! 서비스 로직도 더 깔끔해지고 정렬 기준도 한눈에 보여서 좋은 것 같습니다 :)
| // when | ||
| List<Completeness> result = missionService.findAllMission(userId); | ||
|
|
||
| // then |
There was a problem hiding this comment.
혹시 정렬 부분이 중요하다면, test에서 정렬 부분이 제대로 되는지 검증하는 부분이 있어도 좋을 것같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
(level, title) where display = trueRelated ScreenShot 📷
To Reviewers 📢