-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: ESLint Prettier 공유 config 패키지 생성 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
namdaeun
wants to merge
60
commits into
develop
Choose a base branch
from
refactor/#2_share-config
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 20 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
a491182
chore: eslint-config package.json 으로 의존성 통일
namdaeun 47bd2e0
feat: prettier-config package.json 추가
namdaeun d82607b
refactor: 워크스페이스 패키지 참조
namdaeun 250711b
refactor: root prettier rule 추가
namdaeun c36537d
refactor: root eslint rule 정의
namdaeun b56de7d
chore: update turbo.json
namdaeun a4ac3a1
refactor: 공용 config로 변경
namdaeun e9a728e
chore: yarn install
namdaeun 505bbc4
chore: lint fix script 추가
namdaeun 166e1bd
fix: fix lint errors
namdaeun 3748b55
chore: add prettier scripts
namdaeun ef2e36b
chore: disable react/jsx-key rule
namdaeun f23daaa
chore: yarn install
namdaeun 7c93a78
chore: add eslint and prettier ignore files
namdaeun 537f792
chore: add prettier scripts
namdaeun 647fbad
chore: ignore path 옵션 추가
namdaeun fb9ad57
refactor: 공유 config rules 적용
namdaeun caf99f6
chore: root ignore file로 통일
namdaeun a80b6c8
chore: solve console warnings
namdaeun 961464a
chore: stylelint script 추가
namdaeun c6f2234
chore: update gitignore
namdaeun cba980b
chore: update env
namdaeun 94214a9
chore: dotfile 패턴 추가
namdaeun 9c254cb
chore: trigger workflow
namdaeun c8fe521
chore: remove paths from pull request triggers
namdaeun b1be091
chore: prettier -> format으로 변경
namdaeun 160aa04
feat: lint-staged 추가
namdaeun a7aa96e
chore: modify deprecated rule
namdaeun 29c1fda
refactor: gitignore 루트로 통일
namdaeun 48f8e3a
chore: 불필요한 코드 제거
namdaeun e41a8c9
chore: jsx-key rule 활성화
namdaeun 4eb63ca
chore: 안 쓰이는 트리거 제거
namdaeun 2fb2b4a
chore: 명령어 수정
namdaeun 7cd8def
chore: add check script
namdaeun e43c761
chore: base no-unused-vars 옵션 꺼둠
namdaeun fae0485
chore: type import/export rule 추가
namdaeun 2314587
docs: prettier 패키지로 분리하지 않음
namdaeun 8d9ba0e
chore: yarn install
namdaeun a47fbde
chore: autofix 옵션 추가
namdaeun eb2c899
chore: update scripts
namdaeun f173307
fix: lint-staged에서 Export검사 제외
namdaeun 2123941
chore: import type rule 적용
namdaeun 3e1714c
chore: lint-staged 규칙 정의
namdaeun 1feea94
chore: pull request trigger 추가
namdaeun fcfeb5b
chore: update workflows
namdaeun 470dc6f
chore: merge
namdaeun 8194895
chore: label workflow에서 파일 목록 paginate 처리
namdaeun dde4939
chore: typecheck 명령어 추가
namdaeun 7220188
chore: 앱별 스크립트 삭제
namdaeun 781b6d8
docs: 파일명 변경
namdaeun 8777806
chore: 버전 변경
namdaeun 14027ba
chore: ignorePatterns 추가 및 ignore 파일 삭제
namdaeun 20d36be
chore: 안쓰는 script 삭제
namdaeun a30bc16
chore: 안 쓰이는 script 삭제
namdaeun 97f3e10
chore: sort 명령어 추가
namdaeun c5678a9
chore: update scripts
namdaeun ac809ed
chore: update scripts
namdaeun 992cc34
fix: 버그 우회를 위해 ignore 빈 파일 추가
namdaeun 480110f
chore: 주석 추가
namdaeun 33aad0f
chore: 안 쓰는 워크플로우 제거
namdaeun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # dependencies | ||
| node_modules | ||
|
|
||
| # build outputs | ||
| .next | ||
| out | ||
| dist | ||
|
|
||
| # generated files | ||
| **/__generated__ | ||
|
|
||
| # storybook | ||
| storybook-static |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # dependencies | ||
| node_modules | ||
|
|
||
| # build outputs | ||
| .next | ||
| out | ||
| dist | ||
|
|
||
| # docs | ||
| **/*.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,4 @@ | ||
| { | ||
| "root": true, | ||
| "parser": "@typescript-eslint/parser", | ||
| "env": { | ||
| "es6": true, | ||
| "node": true, | ||
| "browser": true | ||
| }, | ||
| "plugins": ["@typescript-eslint", "prettier", "import"], | ||
| "extends": [ | ||
| "eslint:recommended", | ||
| "plugin:prettier/recommended", | ||
| "plugin:@typescript-eslint/eslint-recommended", | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:react-hooks/recommended", | ||
| "plugin:storybook/recommended" | ||
| ], | ||
| "rules": { | ||
| "@typescript-eslint/no-var-requires": "off", | ||
| "@typescript-eslint/explicit-module-boundary-types": "off", | ||
| "@typescript-eslint/no-empty-function": "off", | ||
| "react-hooks/rules-of-hooks": "error", | ||
| "react-hooks/exhaustive-deps": "warn", | ||
| "react-hooks/set-state-in-effect": "warn", | ||
| "react-hooks/static-components": "warn", | ||
| "react-hooks/immutability": "warn", | ||
| "react-hooks/refs": "warn", | ||
| "react-hooks/incompatible-library": "warn", | ||
| "prettier/prettier": [ | ||
| "error", | ||
| { | ||
| "endOfLine": "auto" | ||
| } | ||
| ], | ||
| "import/no-unused-modules": [1, { "unusedExports": true }], | ||
| "react/no-unstable-nested-components": "off" | ||
| } | ||
| "extends": ["@sopt-makers/eslint-config/next"] | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,4 +11,4 @@ | |
| "Language": "TypeScript", | ||
| "SDK": "@amplitude/analytics-browser@^1.0", | ||
| "Path": "./src/ampli" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.