Merged
Conversation
dev >> main
main << develop
워크스루배너 표시 조건을 변경하고 홈 팝업에 시간 기반 표시 제어, 사용자 세대 확인, 데이터 유효성 검사를 추가하며, 팝업 클릭 동작을 모달 열기에서 링크 열기로 변경합니다. 변경사항
예상 코드 리뷰 노력🎯 3 (Moderate) | ⏱️ ~20분 관련 PR
추천 리뷰어
시🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 프리뷰 배포 확인하기 🚀 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/components/common/HomePopup/HomePopupContainer.tsx`:
- Around line 34-41: The second unconditional guard is overriding the intended
flag logic; keep a single check using showOnlyToRecentGeneration and
isLastGeneration by retaining the existing if (showOnlyToRecentGeneration &&
!isLastGeneration) return null; and remove the later if (!isLastGeneration)
return null; so the component (HomePopupContainer) only hides non-last
generations when showOnlyToRecentGeneration is true.
Comment on lines
+34
to
41
| //최신 기수만 보기 옵션이 활성화인 경우 | ||
| if (showOnlyToRecentGeneration && !isLastGeneration) { | ||
| return null; | ||
| } | ||
|
|
||
| if (!isLastGeneration) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
최근 기수 전용 플래그가 무력화됩니다
showOnlyToRecentGeneration가 false여도 하단의 !isLastGeneration 가드로 인해 항상 최신 기수만 노출됩니다. 플래그 의도대로 동작하려면 단일 조건으로 합쳐야 합니다.
🔧 수정 제안
- //최신 기수만 보기 옵션이 활성화인 경우
- if (showOnlyToRecentGeneration && !isLastGeneration) {
- return null;
- }
-
- if (!isLastGeneration) {
- return null;
- }
+ // 최신 기수 전용 플래그가 켜진 경우에만 제한
+ if ((showOnlyToRecentGeneration ?? true) && !isLastGeneration) {
+ return null;
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| //최신 기수만 보기 옵션이 활성화인 경우 | |
| if (showOnlyToRecentGeneration && !isLastGeneration) { | |
| return null; | |
| } | |
| if (!isLastGeneration) { | |
| return null; | |
| } | |
| // 최신 기수 전용 플래그가 켜진 경우에만 제한 | |
| if ((showOnlyToRecentGeneration ?? true) && !isLastGeneration) { | |
| return null; | |
| } |
🤖 Prompt for AI Agents
In `@src/components/common/HomePopup/HomePopupContainer.tsx` around lines 34 - 41,
The second unconditional guard is overriding the intended flag logic; keep a
single check using showOnlyToRecentGeneration and isLastGeneration by retaining
the existing if (showOnlyToRecentGeneration && !isLastGeneration) return null;
and remove the later if (!isLastGeneration) return null; so the component
(HomePopupContainer) only hides non-last generations when
showOnlyToRecentGeneration is true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤫 쉿, 나한테만 말해줘요. 이슈넘버
🧐 어떤 것을 변경했어요~?
🤔 그렇다면, 어떻게 구현했어요~?
❤️🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.
📸 스크린샷, 없으면 이것 참,, 섭섭한데요?