Conversation
dev to main
dev to main
fix: 딥링크 접근 권한 허용 [To Main]
dev to main
fix: ask 전용 딥링크 파일 cloudflare 배포 설정 변경
fix: 안드로이드 assetlinks 파일 내용 수정
Summary by CodeRabbit
Walkthrough앱 딥링크 지원을 위해 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 프리뷰 배포 확인하기 🚀 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/api/index.ts`:
- Line 83: Replace the insecure console.log(error) with a safe error-logging
flow: do not print the full AxiosError object (which can contain
config.headers.Authorization); instead sanitize or remove the Authorization
header from error.config before logging and log using console.error or a
structured logger. Specifically, locate the console.log(error) occurrence and
change it to either log only non-sensitive fields (e.g., error.message,
error.response?.status, error.response?.data) or clone error.config and
mask/delete config.headers.Authorization prior to calling console.error,
ensuring no Bearer token is emitted to the browser console.
🧹 Nitpick comments (1)
public/.well-known/apple-app-site-association (1)
1-13:functions/.well-known/apple-app-site-association.ts서버리스 함수와 내용이 중복됩니다.
public/.well-known/apple-app-site-association정적 파일과functions/.well-known/apple-app-site-association.ts서버리스 함수가 동일한 경로에서 동일한 콘텐츠를 제공합니다. Cloudflare Pages에서는 함수가 정적 파일보다 우선하므로 이 정적 파일은 사용되지 않을 가능성이 높습니다. 둘 중 하나만 유지하는 것이 혼동을 줄일 수 있습니다.
| ); | ||
|
|
||
| export const handleTokenError = async (error: AxiosError<unknown>) => { | ||
| console.log(error); |
There was a problem hiding this comment.
프로덕션 환경에서 console.log(error) 제거를 권장합니다.
AxiosError 객체에는 config.headers.Authorization에 Bearer 토큰이 포함되어 있어, 전체 에러를 console.log로 출력하면 브라우저 콘솔에 토큰이 노출될 수 있습니다. 디버깅 목적이라면 console.error로 통일하거나, 민감한 정보가 포함되지 않는 메시지만 출력하는 것이 좋습니다.
🔒 제안하는 수정
export const handleTokenError = async (error: AxiosError<unknown>) => {
- console.log(error);
+ console.error('API error:', error.message, error.response?.status);
const originRequest = error.config;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| console.log(error); | |
| export const handleTokenError = async (error: AxiosError<unknown>) => { | |
| console.error('API error:', error.message, error.response?.status); | |
| const originRequest = error.config; |
🤖 Prompt for AI Agents
In `@src/api/index.ts` at line 83, Replace the insecure console.log(error) with a
safe error-logging flow: do not print the full AxiosError object (which can
contain config.headers.Authorization); instead sanitize or remove the
Authorization header from error.config before logging and log using
console.error or a structured logger. Specifically, locate the
console.log(error) occurrence and change it to either log only non-sensitive
fields (e.g., error.message, error.response?.status, error.response?.data) or
clone error.config and mask/delete config.headers.Authorization prior to calling
console.error, ensuring no Bearer token is emitted to the browser console.
3 participants
🤫 쉿, 나한테만 말해줘요. 이슈넘버
🧐 어떤 것을 변경했어요~?
🤔 그렇다면, 어떻게 구현했어요~?
❤️🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.
📸 스크린샷, 없으면 이것 참,, 섭섭한데요?