Conversation
Summary by CodeRabbit
Walkthrough메이커스팀 모집 안내 문구를 38기에서 39기(2026년 8월) 모집 문구로 교체하고, ExpiredButton 라벨을 일부 수정했습니다. 또한 개발 환경 변수 변경사항
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
제안 리뷰어
🐰 축하 시
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 프리뷰 배포 확인하기 🚀 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
src/components/makers/Notifier.tsx (2)
19-22: MEMO 주석이 현재 상태와 맞지 않습니다.Line 19의 주석
MEMO: 38기 모집 시작 시 주석 해제는 38기 모집을 기준으로 작성되었으나, 현재 코드는 39기 모집 안내를 표시하고 있습니다. 향후 유지보수 시 혼란을 방지하기 위해 주석을 업데이트하는 것이 좋겠습니다.✏️ 주석 업데이트 제안
- {/* MEMO: 38기 모집 시작 시 주석 해제 */} + {/* MEMO: 39기 모집 시작 시 주석 해제 */} {/* <Title>현재 38기 makers 팀 모집이 진행 중이에요. 곧 만나요!</Title> */} - <Title>39기 makers 모집은 2026년 8월 중에 진행될 예정이에요.</Title> + {/* TODO: 39기 모집 시작 시 아래 Title로 교체 */} + {/* <Title>현재 39기 makers 팀 모집이 진행 중이에요. 곧 만나요!</Title> */} + <Title>39기 makers 모집은 2026년 8월 중에 진행될 예정이에요.</Title>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/makers/Notifier.tsx` around lines 19 - 22, Update the outdated MEMO comment that refers to "38기" to match the current content about "39기" in this component: change the comment near the Title element (the commented lines around the Title in Notifier.tsx) to reflect that the 39기 모집 message is active (or remove the MEMO if unnecessary) so future maintainers aren't confused; ensure references around the Title and SubTitle comments are consistent with the displayed 39기 text.
58-67: 사용되지 않는 SubTitle 컴포넌트
SubTitlestyled component가 정의되어 있지만 현재 JSX에서는 주석 처리되어 사용되지 않습니다. 모집 기간에 다시 사용할 예정이라면 현재 상태로 유지해도 괜찮으나, 코드 정리 측면에서 주석으로 처리하거나 별도로 관리하는 방안도 고려해볼 수 있습니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/makers/Notifier.tsx` around lines 58 - 67, The SubTitle styled component in Notifier.tsx is defined but unused; either remove the SubTitle declaration or comment it out / move it to a separate styles file and add a TODO note indicating it will be reused for the 모집 기간 UI; if you keep it, add a short comment above the SubTitle declaration referencing its future use so linters/reviewers understand it's intentionally unused.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/components/makers/Notifier.tsx`:
- Around line 19-22: Update the outdated MEMO comment that refers to "38기" to
match the current content about "39기" in this component: change the comment near
the Title element (the commented lines around the Title in Notifier.tsx) to
reflect that the 39기 모집 message is active (or remove the MEMO if unnecessary) so
future maintainers aren't confused; ensure references around the Title and
SubTitle comments are consistent with the displayed 39기 text.
- Around line 58-67: The SubTitle styled component in Notifier.tsx is defined
but unused; either remove the SubTitle declaration or comment it out / move it
to a separate styles file and add a TODO note indicating it will be reused for
the 모집 기간 UI; if you keep it, add a short comment above the SubTitle declaration
referencing its future use so linters/reviewers understand it's intentionally
unused.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.env.development (1)
13-13: dotenv-linter 경고(UnorderedKey)로 인해 품질 체크 노이즈가 발생할 수 있습니다.Line 13 키 순서가 현재 lint 규칙과 충돌합니다. 이 규칙을 유지할 계획이면 키 정렬을 맞추거나, 의도된 순서라면 lint 예외 정책을 명시해 주세요.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.env.development at line 13, The dotenv file has an UnorderedKey lint warning for NEXT_PUBLIC_AUTH_API_URL; either reorder the keys in .env.development so NEXT_PUBLIC_AUTH_API_URL follows the project's expected key sorting (e.g., alphabetical or the established group order) or, if its current position is intentional, add a documented exception to the dotenv-linter configuration explaining the deliberate ordering and whitelist this key/order; update .env.development (and the linter config) accordingly so the UnorderedKey warning is resolved.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.env.development:
- Line 13: The NEXT_PUBLIC_AUTH_API_URL value currently points to an unresolved
domain; update the environment variable NEXT_PUBLIC_AUTH_API_URL to the correct,
DNS-resolvable auth API host used by the app (the same pattern as other
services, e.g. operation.api.dev.sopt.org or the canonical auth domain
registered in infra) so the baseURL in src/api/index.ts resolves locally; verify
the exact hostname with infra/ops and replace the value in .env.development
accordingly (ensure no stray typos like extra subdomain segments).
---
Nitpick comments:
In @.env.development:
- Line 13: The dotenv file has an UnorderedKey lint warning for
NEXT_PUBLIC_AUTH_API_URL; either reorder the keys in .env.development so
NEXT_PUBLIC_AUTH_API_URL follows the project's expected key sorting (e.g.,
alphabetical or the established group order) or, if its current position is
intentional, add a documented exception to the dotenv-linter configuration
explaining the deliberate ordering and whitelist this key/order; update
.env.development (and the linter config) accordingly so the UnorderedKey warning
is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤫 쉿, 나한테만 말해줘요. 이슈넘버
🧐 어떤 것을 변경했어요~?
플그 내 메이커스 모집글 문구를 변경했습니다.
🤔 그렇다면, 어떻게 구현했어요~?
❤️🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.
📸 스크린샷, 없으면 이것 참,, 섭섭한데요?