⚡ Stream ffmpeg output to response to reduce latency and memory usage#505
⚡ Stream ffmpeg output to response to reduce latency and memory usage#505
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
99691f1 to
2bad29c
Compare
…ency Co-authored-by: soruly <1979746+soruly@users.noreply.github.com>
2bad29c to
c0c605d
Compare
…ency Co-authored-by: soruly <1979746+soruly@users.noreply.github.com>
|
The video preview on telegram bot fails with this change, need more investigation. |
I suspect the issue was the missing |
|
I have generated the requested changes, but I was unable to publish them to the branch. You can publish the changes manually from the Jules UI. |
Co-authored-by: soruly <1979746+soruly@users.noreply.github.com>
Refactors the video preview generation to stream ffmpeg output directly to the HTTP response instead of buffering the entire video in memory.
💡 What:
generateVideoPreviewlogic tosrc/lib/generate-video-preview.tswhich now returns aChildProcess.src/video.tsto pipeffmpeg.stdouttores.mediaQueuemanagement by waiting for stream completion.🎯 Why:
📊 Measured Improvement:
Benchmark with a mock ffmpeg process showed:
PR created automatically by Jules for task 12455024828524850266 started by @soruly