Improve hls runtime keep async only databse keys upsweep #27
+4,168
−1,822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… them to improve performance fix haskell#4381
…p error loading and cradle files
Renames getOptions to getOptionsWorker for clarity Removes redundant getOptionsLoop function Ensures session loading is called under the same `Action` context
…oved organization
…work, and plumb test mode - Introduce DirectKey and newDirectKey for internal/ephemeral action keys - Export pattern DirectKey from graph and types modules - Update fromKey/fromKeyType to return Nothing for DirectKey - Render and Show support for DirectKey - Ensure rule machinery rejects DirectKey (no associated rules) - addRule/runRule now error on DirectKey - Use DirectKey for DeliverStatus in pumpActionThread - Avoids using the “root” key and enables per-action identity - Make shakeRunDatabaseForKeysSep test-aware and filter reenqueued work - Add Bool isTesting parameter (propagated from ghcide newSession) - When not testing, filter reenqueued items that are preserved/unaffected - Preservation API changes - incDatabase/incDatabase1 now return a KeySet of preserved work - computeToPreserve returns (unaffected, preservedSet) and uses deliver keys - Refactor runtime deps mapping - Rename databaseRuntimeDep -> databaseRuntimeDepRoot - Track reverse deps as before; additionally record deps under root DirectKey parents - Update insert/delete helpers and add isRootKey predicate - Action queue utility - Export countInProgress for visibility into in-progress actions BREAKING CHANGES: - shakeRunDatabaseForKeysSep now takes an additional Bool (isTesting) - incDatabase/incDatabase1 return KeySet instead of [Key] - databaseRuntimeDep renamed to databaseRuntimeDepRoot and related helpers adjusted Call sites have been updated accordingly in ghcide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.