Skip to content

fix: Wrong effective ID in unpublish notifications #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix: Wrong effective ID in unpublish notifications #1196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/cadet/assessments/assessments.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,7 @@
raw_answer,
force_submit
) do
with {:ok, team} <- find_team(question.assessment.id, cr_id),

Check warning on line 944 in lib/cadet/assessments/assessments.ex

View workflow job for this annotation

GitHub Actions / Run CI 

variable "team" is unused (if the variable is not meant to be used, prefix it with an underscore)
{:ok, submission} <- find_or_create_submission(cr, question.assessment),
{:status, true} <- {:status, force_submit or submission.status != :submitted},
{:ok, _answer} <- insert_or_update_answer(submission, question, raw_answer, cr_id) do
Expand Down Expand Up @@ -1250,9 +1250,17 @@
|> Submission.changeset(%{is_grading_published: false})
|> Repo.update()

# assumption: if team assessment, all team members are under the same avenger
effective_student_id =
if is_nil(submission.student_id) do
Teams.get_first_member(submission.team_id).student_id
else
submission.student_id
end

Notifications.handle_unpublish_grades_notifications(
submission.assessment.id,
Repo.get(CourseRegistration, submission.student_id)
Repo.get(CourseRegistration, effective_student_id)
)

{:ok, nil}
Expand Down Expand Up @@ -2688,7 +2696,7 @@

def has_last_modified_answer?(
question = %Question{},
cr = %CourseRegistration{id: cr_id},

Check warning on line 2699 in lib/cadet/assessments/assessments.ex

View workflow job for this annotation

GitHub Actions / Run CI 

variable "cr_id" is unused (if the variable is not meant to be used, prefix it with an underscore)
last_modified_at,
force_submit
) do
Expand Down
Loading