-
Notifications
You must be signed in to change notification settings - Fork 56
Leaderboard fixes and improvements #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichDom2185
requested changes
Aug 19, 2025
Member
RichDom2185
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nits :)
664086b to
4d81761
Compare
RichDom2185
approved these changes
Aug 19, 2025
Member
RichDom2185
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Didn't have time to test but looks good
sayomaki
added a commit
that referenced
this pull request
Aug 20, 2025
* Use map for options instead * Remove repeating fields selected from total xp subquery * Retrieve only the userids in the course * select_merge operator is not needed * Convert course userid query to pipeline form * Add filter option for including non-students * Fix submissions xp query and use pipeline format * Fix code formatting * Move anonymous function out of inline * Update testcases for new format * Fix test formatting
sayomaki
added a commit
that referenced
this pull request
Sep 16, 2025
* Use map for options instead * Remove repeating fields selected from total xp subquery * Retrieve only the userids in the course * select_merge operator is not needed * Convert course userid query to pipeline form * Add filter option for including non-students * Fix submissions xp query and use pipeline format * Fix code formatting * Move anonymous function out of inline * Update testcases for new format * Fix test formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to make some fixes and changes to the leaderboard backend logic.