Skip to content

Conversation

@sayomaki
Copy link
Contributor

Small PR to make some fixes and changes to the leaderboard backend logic.

  • Update and fix submissions XP query
  • Use pipeline operations instead of direct queries
  • Make query options as parameter map to allow more options

@sayomaki sayomaki requested a review from RichDom2185 August 19, 2025 07:27
@sayomaki sayomaki self-assigned this Aug 19, 2025
@coveralls
Copy link

coveralls commented Aug 19, 2025

Coverage Status

coverage: 90.824% (-0.01%) from 90.836%
when pulling a4ac56b on leaderboard-fix
into 93b07bb on master.

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits :)

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Didn't have time to test but looks good

@RichDom2185 RichDom2185 merged commit 413a358 into master Aug 19, 2025
2 checks passed
@RichDom2185 RichDom2185 deleted the leaderboard-fix branch August 19, 2025 09:18
sayomaki added a commit that referenced this pull request Aug 20, 2025
* Use map for options instead

* Remove repeating fields selected from total xp subquery

* Retrieve only the userids in the course

* select_merge operator is not needed

* Convert course userid query to pipeline form

* Add filter option for including non-students

* Fix submissions xp query and use pipeline format

* Fix code formatting

* Move anonymous function out of inline

* Update testcases for new format

* Fix test formatting
sayomaki added a commit that referenced this pull request Sep 16, 2025
* Use map for options instead

* Remove repeating fields selected from total xp subquery

* Retrieve only the userids in the course

* select_merge operator is not needed

* Convert course userid query to pipeline form

* Add filter option for including non-students

* Fix submissions xp query and use pipeline format

* Fix code formatting

* Move anonymous function out of inline

* Update testcases for new format

* Fix test formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants