Skip to content

Commit 62a37aa

Browse files
committed
Modify actions and sagas to use new redux utils
1 parent cb934b0 commit 62a37aa

File tree

12 files changed

+273
-334
lines changed

12 files changed

+273
-334
lines changed

src/commons/application/actions/SessionActions.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,27 @@ import {
44
unpublishedToBackendParams
55
} from 'src/features/grading/GradingUtils';
66
import { freshSortState } from 'src/pages/academy/grading/subcomponents/GradingSubmissionsTable';
7-
import { OptionType } from 'src/pages/academy/teamFormation/subcomponents/TeamFormationForm';
7+
import type { OptionType } from 'src/pages/academy/teamFormation/subcomponents/TeamFormationForm';
88

9-
import {
9+
import type {
1010
AllColsSortStates,
1111
GradingOverviews,
1212
GradingQuery
1313
} from '../../../features/grading/GradingTypes';
14-
import { TeamFormationOverview } from '../../../features/teamFormation/TeamFormationTypes';
15-
import {
14+
import type { TeamFormationOverview } from '../../../features/teamFormation/TeamFormationTypes';
15+
import type {
1616
Assessment,
1717
AssessmentConfiguration,
1818
AssessmentOverview,
1919
ContestEntry
2020
} from '../../assessment/AssessmentTypes';
21-
import {
21+
import type {
2222
Notification,
2323
NotificationFilterFunction
2424
} from '../../notificationBadge/NotificationBadgeTypes';
2525
import { generateOctokitInstance } from '../../utils/GitHubPersistenceHelper';
2626
import { Role, StoriesRole } from '../ApplicationTypes';
27-
import {
27+
import type {
2828
AdminPanelCourseRegistration,
2929
CourseRegistration,
3030
Tokens,
@@ -153,6 +153,4 @@ const SessionActions = createActions('session', {
153153
});
154154

155155
// For compatibility with existing code (actions helper)
156-
export default {
157-
...SessionActions
158-
};
156+
export default SessionActions

src/commons/redux/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export function createActions<BaseName extends string, BaseActions extends Recor
2828
? createAction(`${baseName}/${name}`, (...args: any) => ({ payload: func(...args) }))
2929
: createAction(`${baseName}/${name}`)
3030
}),
31-
{} as {
31+
{} as Readonly<{
3232
[K in keyof BaseActions]: K extends string
3333
? BaseActions[K] extends (...args: any) => any
3434
? ActionCreatorWithPreparedPayload<
@@ -38,7 +38,7 @@ export function createActions<BaseName extends string, BaseActions extends Recor
3838
>
3939
: ActionCreatorWithoutPayload<`${BaseName}/${K}`>
4040
: never;
41-
}
41+
}>
4242
);
4343
}
4444

0 commit comments

Comments
 (0)