Skip to content

Conversation

@TheMythologist
Copy link
Contributor

@TheMythologist TheMythologist commented Sep 24, 2024

Description

Resolves #3041

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code

@coveralls
Copy link

coveralls commented Sep 24, 2024

Pull Request Test Coverage Report for Build 11142340598

Details

  • 5 of 20 (25.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 31.455%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/achievement/utils/InsertFakeAchievements.ts 0 1 0.0%
src/commons/utils/DateHelper.ts 5 8 62.5%
src/pages/academy/groundControl/subcomponents/GroundControlEditCell.tsx 0 5 0.0%
src/commons/achievement/utils/DateHelper.ts 0 6 0.0%
Totals Coverage Status
Change from base Build 11142332082: 0.006%
Covered Lines: 4855
Relevant Lines: 14550

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@RichDom2185 RichDom2185 enabled auto-merge (squash) October 2, 2024 10:41
@RichDom2185 RichDom2185 merged commit 076fd7a into source-academy:master Oct 2, 2024
6 checks passed
@TheMythologist TheMythologist deleted the migrate-to-dayjs branch October 13, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from moment to dayjs

3 participants