fix: achievements loading and assessment workspace 404 #3073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously not reupdating properly when new data is fetched from the backend.
Pull Request Test Coverage Report for Build 11566119996Details
💛 - Coveralls |
josh1248
approved these changes
Oct 29, 2024
| handleTeamOverviewFetch(props.assessmentId); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []); | ||
| if (assessmentOverview && assessmentOverview.maxTeamSize > 1) { |
| // We only want to create the inferencer once | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| [] | ||
| [initialAchievements, initialGoals] |
Contributor
There was a problem hiding this comment.
good change to enable reload of achievements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3072.
Also fixes a small bug following #3061 so that updated achievements can be redisplayed in the frontend when the backend returns with fresh data.
Type of change
How to test
Checklist