Skip to content

Leaderboard #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 66 commits into from
Aug 7, 2025
Merged

Leaderboard #3113

merged 66 commits into from
Aug 7, 2025

Conversation

@tohyzhong
Copy link
Contributor

@tohyzhong tohyzhong commented Mar 8, 2025 •
edited
Loading

Description

  • Added Overall Leaderboard and Contest Leaderboards
  • XP and contest score fetching from backend
  • podium display for each leaderboard
  • customise number of entries to display in overall leaderboard in course config panel and create courses
  • dropdown to switch between leaderboards
  • routing to different leaderboards (url + dropdown)
  • links for contest entries
  • added contest scores update button in ground control (under voting features)
  • export as CSV for admins and staff
  • contest score updating
  • contest xp issuing for contest winners
  • Fixed code links from leaderboard without using setTimeout
  • Customise XP issuing for contest winners in contest voting XML file
  • Default Source Academy Profile pictures in Leaderboard based on NUSNet ID

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@tohyzhong tohyzhong requested a review from RichDom2185 March 8, 2025 12:15
@tohyzhong tohyzhong self-assigned this Mar 8, 2025
@tohyzhong tohyzhong marked this pull request as ready for review March 9, 2025 10:24
@tohyzhong tohyzhong marked this pull request as draft March 9, 2025 10:25
tohyzhong and others added 12 commits March 10, 2025 00:31
@tohyzhong
Fix import order in AssessmentWorkspace component
5b6755d
@tohyzhong
Refactor contest score calculation logic in Ground Control
62ea438
@Blerargh
Modularisation of Leaderboard subcomponents
1c0c5c2
@Blerargh
Formatting changes
9f2b2a9
@tohyzhong
Dropdown, csv Export, Podium fixes
7f65d1c
@tohyzhong
Set filename for Contests and Overall Leaderboard csv
b72b813
@RichDom2185
Use no payload type
1360753
@RichDom2185
Remove unused parameter
4aed281
@tohyzhong
Refactor LeaderboardExportButton to accept dynamic type and update fi…
75ec8a1 
…lename logic
@tohyzhong
Add contests state and actions to leaderboard management.
ba4b33b 
Added top X for contest Leaderboard (create course dropdown and course admin panel)
Added Top X for assessment workspace contest leaderboard and fixed export contest leaderboard (assessment workspace)
Fixed Leaderboard dropdown to show only published contests and omit voting assessments.
@tohyzhong
Add DispatchContestXp functionality and button to issue contest XP in…
b78304a 
… ground control
@tohyzhong
Refactor leaderboard components to use slice for top entries instead …
0a41698 
…of filter
@tohyzhong tohyzhong marked this pull request as ready for review March 18, 2025 17:02
@tohyzhong tohyzhong marked this pull request as draft March 18, 2025 17:02
@tohyzhong
Enhance leaderboard functionality to support visible entries in conte…
2ea8cf0 
…st scores and popular votes, update API endpoints, and refactor export button logic.
tohyzhong and others added 12 commits April 30, 2025 18:30
@tohyzhong
Update Contest Leaderboard export to support all users
7c07b48
@tohyzhong
Refactor leaderboard saga and actions for improved readability and ma…
4859269 
…intainability; update ContestLeaderboard and OverallLeaderboard components for better state management and data retrieval.
@tohyzhong
Fix API endpoint in getScoreLeaderboard and disable pagination page s…
f845af9 
…ize selector in OverallLeaderboard
@Blerargh
Updated leaderboard display backend requests to use query parameters;…
dcab05c 
… Offset calculation shifted from backend to frontend
@tohyzhong
Refactor leaderboard export button to escape code fields and update c…
5666396 
…olumn names for clarity; enhance data handling in CSV export.
@tohyzhong
Fix API endpoints in getScoreLeaderboard and getPopularVoteLeaderboar…
a44480e 
…d by removing 'admin' from the URL path.
@Blerargh
Merge branch 'master' into leaderboard
154c947
@Blerargh
Refactor leaderboard saga handlers to use action type constants
9a47542
@Blerargh
Minor formatting fix
9873dfd
@Blerargh
Add fromContestLeaderboard property to defaultProps in AssessmentWork…
dfbe92a 
…space tests
@Blerargh
Merge branch 'leaderboard' of https://github.com/source-academy/frontend
b0ff599 
 into leaderboard
@Blerargh
Removed obsolete snapshots
036d2d9
@coveralls
Copy link

coveralls commented Jun 10, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16799105886

Details

  • 162 of 1104 (14.67%) changed or added relevant lines in 32 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.6%) to 43.464%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/assessment/Assessment.tsx 2 4 50.0%
src/commons/assessmentWorkspace/AssessmentWorkspace.tsx 12 15 80.0%
src/pages/academy/groundControl/configureControls/ExportScoreLeaderboardButton.tsx 0 3 0.0%
src/pages/academy/groundControl/subcomponents/GroundControlConfigureCell.tsx 0 4 0.0%
src/features/leaderboard/LeaderboardActions.ts 19 25 76.0%
src/pages/academy/groundControl/configureControls/ExportVoteLeaderboardButton.tsx 0 6 0.0%
src/pages/academy/academyRoutes.tsx 0 8 0.0%
src/pages/academy/adminPanel/AdminPanel.tsx 0 12 0.0%
src/commons/dropdown/DropdownCreateCourse.tsx 32 48 66.67%
src/pages/academy/groundControl/configureControls/CalculateContestScoreButton.tsx 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
src/pages/academy/academyRoutes.tsx 1 0.0%
src/commons/sagas/RequestsSaga.ts 4 20.03%
Totals Coverage Status
Change from base Build 16762561380: -0.6%
Covered Lines: 20503
Relevant Lines: 49349
💛 - Coveralls

@martin-henz martin-henz requested a review from sayomaki June 10, 2025 12:37
@sayomaki
Copy link
Contributor

sayomaki commented Jun 16, 2025

Corresponding backend PR: source-academy/backend#1238

@RichDom2185 RichDom2185 marked this pull request as draft June 27, 2025 17:57
@sayomaki sayomaki marked this pull request as ready for review August 5, 2025 07:17
sayomaki
sayomaki approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will get this merged first and improvements will be made in a follow-up PR.

@sayomaki sayomaki merged commit a9734b5 into master Aug 7, 2025
9 checks passed
@sayomaki sayomaki deleted the leaderboard branch August 7, 2025 08:24
@sayomaki sayomaki mentioned this pull request Aug 7, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sayomaki sayomaki sayomaki approved these changes

@RichDom2185 RichDom2185 Awaiting requested review from RichDom2185

Assignees

@Blerargh Blerargh

@tohyzhong tohyzhong

Labels

None yet

Projects

SA 2526 CP3108 P09: Leaderboard
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tohyzhong @sayomaki @coveralls @Blerargh @RichDom2185 @martin-henz