Skip to content

Conversation

@heyzec
Copy link
Contributor

@heyzec heyzec commented Mar 24, 2025

Description

FYP: Source Academy as Visual Studio Code Extension

This is a minor change to add a new route /login/vscode_callback, which is a variant of /login/callback. It saves auth tokens into the Redux store after obtaining it via an exchange with a temp token.

See source-academy/backend#1240

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@heyzec heyzec requested a review from RichDom2185 March 24, 2025 16:40
@heyzec heyzec self-assigned this Mar 24, 2025
@coveralls
Copy link

coveralls commented Mar 24, 2025

Pull Request Test Coverage Report for Build 14174579916

Details

  • 1 of 15 (6.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 31.104%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/login/LoginVscodeCallback.tsx 0 14 0.0%
Totals Coverage Status
Change from base Build 14054407863: -0.02%
Covered Lines: 4888
Relevant Lines: 14823

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) March 31, 2025 14:54
@RichDom2185 RichDom2185 merged commit 2665d0d into master Mar 31, 2025
8 checks passed
@RichDom2185 RichDom2185 deleted the vscode/auth branch March 31, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants