Skip to content

Fix #3141 #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Fix #3141 #3142

merged 1 commit into from
Jun 24, 2025

Conversation

@leeyi45
Copy link
Contributor

@leeyi45 leeyi45 commented Jun 24, 2025

A quick PR to fix #3141

@coveralls
Copy link

coveralls commented Jun 24, 2025

Pull Request Test Coverage Report for Build 15844698969

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.707%
Totals Coverage Status
Change from base Build 15677232346: 0.0%
Covered Lines: 10081
Relevant Lines: 21129
💛 - Coveralls

sayomaki
sayomaki approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RichDom2185 RichDom2185 merged commit ab860cb into master Jun 24, 2025
9 checks passed
@RichDom2185 RichDom2185 deleted the fix-3141 branch June 24, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sayomaki sayomaki sayomaki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Share button broken

5 participants

@leeyi45 @coveralls @sayomaki @RichDom2185