Bump prettier, ace-builds, and misc clean up #1741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsammeow
reviewed
Feb 26, 2025
src/__tests__/mode.ts
Outdated
|
|
||
| // define session | ||
| const session = ace.createEditSession('', DefaultMode) | ||
| const session = ace.createEditSession('', new DefaultMode.Mode()) |
There was a problem hiding this comment.
what does this change do, doesn't seem to be building?
Member
Author
There was a problem hiding this comment.
There's a TS type error otherwise, looking into it
There was a problem hiding this comment.
i'd be happy to approve the other two upgrades if you want to get those through first
RichDom2185
force-pushed
the
richard/deps-2502
branch
from
bc773cc to
8779560
Compare
…nto richard/deps-2502
RichDom2185
changed the title
Pull Request Test Coverage Report for Build 13750610219Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To take advantage of prebuilds. Also major bump for Prettier to align with other repositories, even if their defaults differ from Source coding standard.
Checklist