-
Notifications
You must be signed in to change notification settings - Fork 108
Remove lazy #1743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lazy #1743
Conversation
martin-henz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This cleanup is badly needed.
RichDom2185
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there anything that necessitated an upgrade to Yarn 4? I'm personally not against it, but it seems to be causing CI issues every time I tried it in #1630. Are you able to figure out the CI issues? If not, let's revert the yarn change for now
Well when I was working on the frontend I had to switch to Yarn 4. If we don't switch to Yarn 4 then I'll be switching back and forth between Yarn versions. |
True, I'm still not sure why the resolution is failing at CI but not locally though |
|
@martin-henz has indicated that we can just remove the GPU variant. I'll go ahead with doing that. |
Pull Request Test Coverage Report for Build 13622100329Details
💛 - Coveralls |
|
Updated the wiki to indicate that gpu acceleration is discontinued: https://github.com/source-academy/js-slang/wiki/GPU-Acceleration-%5Bdiscontinued%5D |
|
Updated the wiki to indicate that the lazy variants are discontinued: |
Removes the lazy variant from
js-slang