Skip to content

Conversation

@leeyi45
Copy link
Contributor

@leeyi45 leeyi45 commented Feb 28, 2025

Removes the lazy variant from js-slang

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This cleanup is badly needed.

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there anything that necessitated an upgrade to Yarn 4? I'm personally not against it, but it seems to be causing CI issues every time I tried it in #1630. Are you able to figure out the CI issues? If not, let's revert the yarn change for now

@leeyi45
Copy link
Contributor Author

leeyi45 commented Mar 3, 2025

Was there anything that necessitated an upgrade to Yarn 4? I'm personally not against it, but it seems to be causing CI issues every time I tried it in #1630. Are you able to figure out the CI issues? If not, let's revert the yarn change for now

Well when I was working on the frontend I had to switch to Yarn 4. If we don't switch to Yarn 4 then I'll be switching back and forth between Yarn versions.

@RichDom2185
Copy link
Member

Was there anything that necessitated an upgrade to Yarn 4? I'm personally not against it, but it seems to be causing CI issues every time I tried it in #1630. Are you able to figure out the CI issues? If not, let's revert the yarn change for now

Well when I was working on the frontend I had to switch to Yarn 4. If we don't switch to Yarn 4 then I'll be switching back and forth between Yarn versions.

True, I'm still not sure why the resolution is failing at CI but not locally though

@leeyi45
Copy link
Contributor Author

leeyi45 commented Mar 3, 2025

@martin-henz has indicated that we can just remove the GPU variant. I'll go ahead with doing that.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13622100329

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • 15 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.005%) to 81.126%

Files with Coverage Reduction New Missed Lines %
src/utils/operators.ts 1 93.16%
src/utils/stringify.ts 1 80.52%
src/utils/ast/astCreator.ts 3 82.57%
src/interpreter/interpreter.ts 10 89.21%
Totals Coverage Status
Change from base Build 13616209329: -0.005%
Covered Lines: 10762
Relevant Lines: 12898

💛 - Coveralls

@martin-henz martin-henz merged commit e35223f into master Mar 3, 2025
4 checks passed
@martin-henz martin-henz deleted the remove-lazy branch March 3, 2025 05:58
@leeyi45 leeyi45 mentioned this pull request Mar 3, 2025
@martin-henz
Copy link
Member

Updated the wiki to indicate that gpu acceleration is discontinued: https://github.com/source-academy/js-slang/wiki/GPU-Acceleration-%5Bdiscontinued%5D

@martin-henz
Copy link
Member

Updated the wiki to indicate that the lazy variants are discontinued:
https://github.com/source-academy/js-slang/wiki/Lazy-Evaluation-%5Bdiscontinued%5D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants