Change Equipment.Type property to a string property named SubclassName

The underlying EquipmentType enum wasn't being used directly. Its
definition had some redundancies with the EquipmentClass enum.

Rename the property to something clearer; the difference between the
terms "Type" and "Class" is vague.

Author: MarkKoz

src/SourceEngine.Demo.Parser/Events.cs

@@ -474,27 +474,23 @@ public class Equipment
 
 		public EquipmentClass Class => (EquipmentClass)((int)Weapon / 100 + 1);
 
-		public EquipmentType Type
+		public string SubclassName
 		{
 			get
 			{
 				return Weapon switch
 				{
-					EquipmentElement.M249 => EquipmentType.LMG,
-					EquipmentElement.Negev => EquipmentType.LMG,
-					EquipmentElement.Scout => EquipmentType.Sniper,
-					EquipmentElement.AWP => EquipmentType.Sniper,
-					EquipmentElement.Zeus => EquipmentType.Zeus,
-					EquipmentElement.Knife => EquipmentType.Knife,
+					EquipmentElement.M249 => "LMG",
+					EquipmentElement.Negev => "LMG",
+					EquipmentElement.Scout => "Sniper",
+					EquipmentElement.AWP => "Sniper",
+					EquipmentElement.Zeus => "Zeus",
+					EquipmentElement.Knife => "Knife",
 					_ => Class switch
 					{
-						EquipmentClass.Heavy => EquipmentType.Shotgun,
-						EquipmentClass.Rifle => EquipmentType.AssaultRifle,
-						EquipmentClass.Equipment => EquipmentType.Equipment,
-						EquipmentClass.Pistol => EquipmentType.Pistol,
-						EquipmentClass.SMG => EquipmentType.SMG,
-						EquipmentClass.Grenade => EquipmentType.Grenade,
-						_ => EquipmentType.Unknown
+						EquipmentClass.Heavy => "Shotgun",
+						EquipmentClass.Rifle => "AssaultRifle",
+						_ => Class.ToString()
 					}
 				};
 			}
@@ -754,19 +750,4 @@ public enum EquipmentClass
 		Equipment = 5,
 		Grenade = 6,
 	}
-
-	public enum EquipmentType // added to separate weapon groups better
-	{
-		Unknown = 0,
-		Pistol = 1,
-		SMG = 2,
-		LMG = 3,
-		Shotgun = 4,
-		AssaultRifle = 5,
-		Sniper = 6,
-		Grenade = 7,
-		Zeus = 8,
-		Knife = 9,
-		Equipment = 10,
-	}
 }

src/SourceEngine.Demo.Stats/DemoProcessor.cs

@@ -1398,7 +1398,7 @@ public List<hostageStats> GetHostageStats(ProcessedData processedData)
 		{
 			List<hostageStats> hostageStats = new List<hostageStats>();
 
-			var hostageIndexA = processedData.HostageRescueValues.Where(r => r.Hostage == 'A').FirstOrDefault()?.HostageIndex;	
+			var hostageIndexA = processedData.HostageRescueValues.Where(r => r.Hostage == 'A').FirstOrDefault()?.HostageIndex;
 			var hostageIndexB = processedData.HostageRescueValues.Where(r => r.Hostage == 'B').FirstOrDefault()?.HostageIndex;
 
 			List<char> hostagePickedUps = new List<char>(processedData.HostagePickedUpValues.Select(x => x.Hostage));
@@ -1539,7 +1539,7 @@ public List<killsStats> GetKillsStats(ProcessedData processedData, Dictionary<lo
 
 						var weaponUsed = weaponKillers.ElementAt(i).Weapon.ToString();
 						var weaponUsedClass = weaponKillers.ElementAt(i).Class.ToString();
-						var weaponUsedType = weaponKillers.ElementAt(i).Type.ToString();
+						var weaponUsedType = weaponKillers.ElementAt(i).SubclassName;
 						var numOfPenetrations = penetrations.ElementAt(i);
 
 						if (weaponUsed == null || weaponUsed == string.Empty)
@@ -1919,7 +1919,7 @@ public List<firstDamageStats> GetFirstDamageStats(ProcessedData processedData)
 							ZPositionVictim = firstDamage.ZPositionPlayer,
 							Weapon = firstDamage.Weapon.Weapon.ToString(),
 							WeaponClass = firstDamage.Weapon.Class.ToString(),
-							WeaponType = firstDamage.Weapon.Type.ToString(),
+							WeaponType = firstDamage.Weapon.SubclassName,
 						};
 
 						firstDamageStats[round - 1].FirstDamageToEnemyByPlayers.Add(firstDamageByPlayer);
@@ -2254,7 +2254,7 @@ public bool GetIfTeamSwapOrdersAreNormalOrderByHalfAndOvertimeCount(string half,
 		public static int? GetMinRoundsForWin(string testType)
 		{
 			string gamemode = testType.ToLower();
-			
+
 			if (gamemode == "unknown")
 			{
 				return null;