Skip to content

Run fast clippy/fmt/typos before relatively slow tests #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sourcefrog merged 3 commits into from
Jan 12, 2025
Merged

Run fast clippy/fmt/typos before relatively slow tests #482

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
458f6d3
Run fast clippy/fmt/typos before relatively slow tests
sourcefrog Jan 10, 2025
ae6ccdb
Also check rustfmt/clippy earlier on other platforms
sourcefrog Jan 10, 2025
63c2515
Build before installing nextest
sourcefrog Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,18 @@ jobs:
rustc --version
- name: Build
run: cargo build --all-targets
- uses: taiki-e/install-action@v2
name: Install nextest using install-action
with:
tool: nextest
- name: Test
run: cargo test --workspace
- name: Check rustfmt
run: cargo fmt --all --check
- name: Check clippy
run: cargo clippy --all-targets --all-features -- -D warnings
- name: Check typos
uses: crate-ci/typos@master
- uses: taiki-e/install-action@v2
name: Install nextest using install-action
with:
tool: nextest
- name: Test
run: cargo test --workspace
- name: Build release binary
run: cargo build --release
- name: Upload binary artifact
Expand Down Expand Up @@ -87,23 +87,21 @@ jobs:
cargo --version
rustc --version
- uses: Swatinem/rust-cache@v2
- name: rustfmt
run: cargo fmt --all -- --check
- uses: taiki-e/install-action@v2
name: Install nextest using install-action
with:
tool: nextest
- name: Build
run: cargo build --all-targets
- name: Test
run: cargo test --workspace
- name: Check rustfmt
run: cargo fmt --all --check
- name: Check clippy
if: matrix.version == 'stable'
# Clippy checks can vary between versions in a way that makes it a bit
# fiddly to satisfy them all, so only insist that they pass on stable.
run: cargo clippy --all-targets --all-features -- -D warnings
- name: Build
run: cargo build --all-targets
- uses: taiki-e/install-action@v2
name: Install nextest using install-action
with:
tool: nextest
- name: Test
run: cargo test --workspace
- run: cargo update
- name: Test after cargo update
run: cargo test --workspace
Expand Down
Loading