Remove ^= as mutation for |= and &= operators#556
Merged
sourcefrog merged 2 commits intomainfrom Oct 6, 2025
Merged
Conversation
Copilot
AI
changed the title
[WIP] Reconsider
Remove ^= as mutation for |= and &= operators
Oct 6, 2025
replace |= with ^=Co-authored-by: sourcefrog <346355+sourcefrog@users.noreply.github.com>
3b8c14a to
ffec8db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When mutating bitwise assignment operators, cargo-mutants was suggesting replacing
|=with^=(and&=with^=). However, this mutation is uninformative for the common pattern of accumulating bits into a bitmap that starts from zero:In this code (from Zed's
crates/rope/src/chunk.rs), when accumulating new set bits into a bitmap that's initially zeros,|=and^=produce identical results. The mutation doesn't actually test anything different.Solution
Changed the mutation patterns for bitwise assignment operators:
&=now only mutates to|=(removed^=)|=now only mutates to&=(removed^=)^=still mutates to both|=and&=(unchanged)This makes the mutations more meaningful by ensuring they actually change the behavior in typical usage patterns.
Changes
src/visit.rsbook/src/mutants.mdwith explicit entries for bitwise assignment operatorsNEWS.mdmutate_assign_opstestOriginal prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.