-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): add support for angular v17 #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ajay-prajapati07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz add a small video evidence of working.
Screen.Recording.2025-06-19.at.2.57.24.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades Angular and related dependencies to version 17 across all packages and the sandbox example. Key changes include:
- Bump Angular core, Material, CDK, flex-layout, RxJS, Zone.js, TypeScript, and CLI versions to support v17.
- Update build script in
search-libproject to explicitly target the library. - Refresh hash in
search-elementpackage.
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sandbox/search-client-example/package.json | Upgraded Angular and runtime dependencies to v17 |
| packages/search/projects/search-lib/package.json | Bumped peerDependencies to Angular v17; adjusted build |
| packages/search/projects/search-element/package.json | Updated package hash |
| packages/search/package.json | Upgraded dependencies and devDependencies to Angular v17 |
| "@angular/platform-browser-dynamic": "^17.3.0", | ||
| "@angular/router": "^17.3.0", | ||
| "rxjs": "~7.8.1", | ||
| "zone.js": "~0.14.3" |
Copilot
AI
Jun 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The zone.js version here (~0.14.3) differs from ^0.14.1 in other packages; consider aligning the exact version specifier across all modules to avoid potential integration issues.
| "zone.js": "~0.14.3" | |
| "zone.js": "^0.14.1" |
| "@angular/platform-browser": "^17.3.0", | ||
| "@angular/platform-browser-dynamic": "^17.3.0", | ||
| "@angular/router": "^17.3.0", | ||
| "rxjs": "^7.8.1", |
Copilot
AI
Jun 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The rxjs version specifier here (^7.8.1) is inconsistent with the peer dependency in search-lib (~7.8.1); unifying the specifier style can help maintain consistency.
| "rxjs": "^7.8.1", | |
| "rxjs": "~7.8.1", |
BREAKING CHANGE:
search library does not support angular v17
Issue- (GH-28)
Description
Updated the angular version and its dependencies
Support for angular version 17
Fixes #28
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: