Skip to content

Conversation

@piyushsinghgaur1
Copy link
Contributor

@piyushsinghgaur1 piyushsinghgaur1 commented Jun 18, 2025

BREAKING CHANGE:
search library does not support angular v17

Issue- (GH-28)

Description

Updated the angular version and its dependencies
Support for angular version 17

Fixes #28

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@piyushsinghgaur1 piyushsinghgaur1 self-assigned this Jun 18, 2025
@piyushsinghgaur1 piyushsinghgaur1 added the enhancement New feature or request label Jun 18, 2025
Copy link

@ajay-prajapati07 ajay-prajapati07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz add a small video evidence of working.

@piyushsinghgaur1
Copy link
Contributor Author

Plz add a small video evidence of working.

Screen.Recording.2025-06-19.at.2.57.24.PM.mov

@rohit-sourcefuse rohit-sourcefuse requested a review from Copilot June 20, 2025 05:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades Angular and related dependencies to version 17 across all packages and the sandbox example. Key changes include:

  • Bump Angular core, Material, CDK, flex-layout, RxJS, Zone.js, TypeScript, and CLI versions to support v17.
  • Update build script in search-lib project to explicitly target the library.
  • Refresh hash in search-element package.

Reviewed Changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.

File Description
sandbox/search-client-example/package.json Upgraded Angular and runtime dependencies to v17
packages/search/projects/search-lib/package.json Bumped peerDependencies to Angular v17; adjusted build
packages/search/projects/search-element/package.json Updated package hash
packages/search/package.json Upgraded dependencies and devDependencies to Angular v17

"@angular/platform-browser-dynamic": "^17.3.0",
"@angular/router": "^17.3.0",
"rxjs": "~7.8.1",
"zone.js": "~0.14.3"
Copy link

Copilot AI Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The zone.js version here (~0.14.3) differs from ^0.14.1 in other packages; consider aligning the exact version specifier across all modules to avoid potential integration issues.

Suggested change
"zone.js": "~0.14.3"
"zone.js": "^0.14.1"

Copilot uses AI. Check for mistakes.
"@angular/platform-browser": "^17.3.0",
"@angular/platform-browser-dynamic": "^17.3.0",
"@angular/router": "^17.3.0",
"rxjs": "^7.8.1",
Copy link

Copilot AI Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The rxjs version specifier here (^7.8.1) is inconsistent with the peer dependency in search-lib (~7.8.1); unifying the specifier style can help maintain consistency.

Suggested change
"rxjs": "^7.8.1",
"rxjs": "~7.8.1",

Copilot uses AI. Check for mistakes.
@rohit-sourcefuse rohit-sourcefuse changed the title feat(deps): add support for angular v17 chore(deps): add support for angular v17 Jun 20, 2025
@rohit-sourcefuse rohit-sourcefuse merged commit 3f66e25 into master Jun 20, 2025
2 checks passed
@rohit-sourcefuse rohit-sourcefuse deleted the GH-28 branch June 20, 2025 05:25
@a-ganguly a-ganguly added the breaking breaking change label Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking breaking change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@sourceloop/search-client: Update version of dependencies

6 participants