-
Notifications
You must be signed in to change notification settings - Fork 0
feat(user-onboarding): convert into workspace #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vaibhavbhalla2505
wants to merge
2
commits into
user-onboarding-v19
Choose a base branch
from
GH-68
base: user-onboarding-v19
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+22,853
−24,273
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,17 +22,14 @@ jobs: | |
| - run: node --version | ||
| - run: npm --version | ||
|
|
||
| - name: Install Chrome | ||
| uses: browser-actions/setup-chrome@v1 | ||
|
|
||
| - name: Install Monorepo Deps | ||
| run: npm ci --ignore-scripts | ||
|
|
||
| - name: Install Lerna | ||
| run: npm i -g [email protected] --ignore-scripts | ||
|
|
||
| - name: Bootstrap Monorepo | ||
| run: lerna bootstrap --ignore-scripts | ||
|
|
||
| - name: Run Test Cases | ||
| run: npx lerna run test | ||
| run: npm run test --workspaces --if-present | ||
|
|
||
| - name: Run Lint Checks | ||
| run: npx lerna run lint | ||
| run: npm run lint --workspaces --if-present | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,11 +23,5 @@ jobs: | |
| if: steps.cache-nodemodules.outputs.cache-hit != 'true' | ||
| run: npm ci --ignore-scripts | ||
|
|
||
| - name: Install Lerna | ||
| run: npm i -g [email protected] --ignore-scripts | ||
|
|
||
| - name: Bootstrap Monorepo | ||
| run: lerna bootstrap --ignore-scripts | ||
|
|
||
| - name: Run test | ||
| run: lerna run test | ||
| run: npm run test --workspaces --if-present | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,14 +8,14 @@ jobs: | |
| Release: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| # fetch-depth is necessary to get all tags | ||
| # otherwise lerna can't detect the changes and will end up bumping the versions for all packages | ||
| fetch-depth: 0 | ||
| token: ${{ secrets.RELEASE_COMMIT_GH_PAT }} | ||
| - name: Setup Node | ||
| uses: actions/setup-node@v3 | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20.x' | ||
| - name: Configure CI Git User | ||
|
|
@@ -29,29 +29,23 @@ jobs: | |
| CONFIG_EMAIL: ${{ vars.RELEASE_COMMIT_EMAIL }} | ||
| - name: Authenticate with Registry | ||
| run: | | ||
| echo "@${NPM_USERNAME}:registry=https://registry.npmjs.org/" > .npmrc | ||
| echo "registry=https://registry.npmjs.org/" >> .npmrc | ||
| echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> .npmrc | ||
| echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" > .npmrc | ||
| npm whoami | ||
| env: | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| NPM_USERNAME: ${{ vars.NPM_USERNAME }} | ||
|
|
||
| - name: Bootstrap | ||
| - name: Install Dependencies | ||
| run: | | ||
| npm ci --ignore-scripts | ||
| npm i -g [email protected] --ignore-scripts | ||
| lerna bootstrap --ignore-scripts | ||
| - name: Test | ||
| run: npx lerna run test | ||
| run: npm run test --workspaces --if-present | ||
| - name: Stash Changes | ||
| run: git stash | ||
| - name: Bump Versions | ||
| # "HUSKY=0" disables pre-commit-msg check (Needed in order to allow lerna perform the release commit) | ||
| run: HUSKY=0 npx lerna version --yes --ci --conventional-commits | ||
| - name: Publish to NPM 🚀 | ||
| # To always compare changes from registry | ||
| # using `from-package` compares version in local package.json with registry and publish it if required. | ||
| run: npx lerna publish from-package --yes | ||
| env: | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for user-onboarding ---- change the packages property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!