fix(db-query): minor fix in dataset action update

MIGRATION CHANGE:
migration-20250923054319- added index for unique user action

Author: akshatdubeysf

migrations/pg/migrations/sqls/20250923054319-init-up.sql

@@ -98,4 +98,6 @@ update
 create trigger mdt_chats before
 update
     on
-    chatbot.chats for each row execute function chatbot.moddatetime('modified_on');
+    chatbot.chats for each row execute function chatbot.moddatetime('modified_on');
+
+CREATE UNIQUE INDEX unique_user_action ON chatbot.dataset_actions(user_id, dataset_id);

src/__tests__/db-query/acceptance/dataset.controller.acceptance.ts

@@ -160,9 +160,13 @@ describe('DatasetController', () => {
         .send(updatedData)
         .expect(204);
 
-      const dataset = await repo.findById(dummyDataset.id, {
-        include: ['actions'],
-      });
+      const dataset = await repo.findById(
+        dummyDataset.id,
+        {
+          include: ['actions'],
+        },
+        {skipUserFilter: true},
+      );
       expect(dataset).to.have.property('votes', 1);
       expect(dataset.actions).to.be.Array();
       expect(dataset.actions).to.have.length(1);
@@ -270,7 +274,7 @@ describe('DatasetController', () => {
         .send(updatedData)
         .expect(400);
     });
-    it('should should increment votes for different user', async () => {
+    it('should increment votes for different user', async () => {
       await client
         .patch(`/datasets/${dummyDataset.id}`)
         .set(
@@ -288,14 +292,18 @@ describe('DatasetController', () => {
         )
         .send({liked: true})
         .expect(204);
-      const dataset = await repo.findById(dummyDataset.id, {
-        include: ['actions'],
-      });
+      const dataset = await repo.findById(
+        dummyDataset.id,
+        {
+          include: ['actions'],
+        },
+        {skipUserFilter: true},
+      );
       expect(dataset).to.have.property('votes', 2);
       expect(dataset.actions).to.be.Array();
       expect(dataset.actions).to.have.length(2);
     });
-    it('should should cancel votes for different user', async () => {
+    it('should cancel votes for different users', async () => {
       await client
         .patch(`/datasets/${dummyDataset.id}`)
         .set(
@@ -313,14 +321,18 @@ describe('DatasetController', () => {
         )
         .send({liked: false, comment: 'Not good'})
         .expect(204);
-      const dataset = await repo.findById(dummyDataset.id, {
-        include: ['actions'],
-      });
+      const dataset = await repo.findById(
+        dummyDataset.id,
+        {
+          include: ['actions'],
+        },
+        {skipUserFilter: true},
+      );
       expect(dataset).to.have.property('votes', 0);
       expect(dataset.actions).to.be.Array();
       expect(dataset.actions).to.have.length(2);
     });
-    it('should handle muliple dislikes only', async () => {
+    it('should handle muliple dislikes from different users', async () => {
       await client
         .patch(`/datasets/${dummyDataset.id}`)
         .set(
@@ -338,9 +350,13 @@ describe('DatasetController', () => {
         )
         .send({liked: false, comment: 'Not good'})
         .expect(204);
-      const dataset = await repo.findById(dummyDataset.id, {
-        include: ['actions'],
-      });
+      const dataset = await repo.findById(
+        dummyDataset.id,
+        {
+          include: ['actions'],
+        },
+        {skipUserFilter: true},
+      );
       expect(dataset).to.have.property('votes', -2);
       expect(dataset.actions).to.be.Array();
       expect(dataset.actions).to.have.length(2);
@@ -396,7 +412,7 @@ describe('DatasetController', () => {
     const ctx = new Context(appInstance);
     ctx.bind(AuthenticationBindings.CURRENT_USER).to({
       id: 'test-user',
-      userTenantId: 'default',
+      userTenantId: 'default-user-id',
     } as unknown as IAuthUserWithPermissions);
     const dsrepo = await ctx.get<DataSetRepository>(
       `repositories.${DataSetRepository.name}`,

src/__tests__/test-helper.ts

@@ -189,7 +189,10 @@ export async function seedDataset(appInstance: TestApp) {
   });
 }
 
-export function buildToken(permissions: string[], userTenantId = 'default') {
+export function buildToken(
+  permissions: string[],
+  userTenantId = 'default-user-id',
+) {
   return sign(
     {
       id: 'test-user',
@@ -248,7 +251,8 @@ export async function getRepo(app: Application, repo: string) {
   const ctx = new Context(app);
   ctx.bind(AuthenticationBindings.CURRENT_USER).to({
     id: 'test-user',
-    userTenantId: 'default',
+    userTenantId: 'default-user-id',
+    role: 'admin',
   } as unknown as IAuthUserWithPermissions);
   return ctx.get<DataSetRepository>(`repositories.${DataSetRepository.name}`);
 }

src/components/db-query/repositories/dataset-action.repository.ts

@@ -28,9 +28,12 @@ export class DatasetActionRepository extends DefaultTransactionalRepository<
     options?: Options,
   ): Promise<DatasetAction[]> {
     const user = await this.getCurrentUser();
+    if (options?.skipUserFilter === true) {
+      return super.find(filter, options);
+    }
     filter = filter ?? {};
     filter.where = {
-      and: [filter.where ?? {}, {userId: user.tenantId}],
+      and: [filter.where ?? {}, {userId: user.userTenantId}],
     };
     return super.find(filter, options);
   }