Skip to content

Conversation

@manikanta-sadurla
Copy link
Contributor

@manikanta-sadurla manikanta-sadurla commented Nov 7, 2025

Description

Update Custom Tags for Subnet specific

Related Issue

Checklist

Please ensure that the following steps are completed before submitting the pull request:

  • Code follows the Terraform best practices and style guidelines.
  • Changes are appropriately documented, including any necessary updates to README or other documentation files.
  • Unit tests have been added or updated to cover the changes introduced by this pull request.
  • Changes have been tested locally and verified to work as expected.
  • The code has been reviewed to ensure it aligns with the project's goals and standards.
  • Dependencies and backward compatibility have been considered and addressed if applicable.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Testing Instructions

Usage Examples

Simple mode (auto-generated subnets) with EKS tags:

module "network" {
  availability_zones = ["us-east-1a", "us-east-1b"]
  
  additional_public_subnet_tags = {
    "kubernetes.io/role/elb" = "1"
    "kubernetes.io/cluster/my-cluster" = "shared"
  }
  
  additional_private_subnet_tags = {
    "kubernetes.io/role/internal-elb" = "1"
    "kubernetes.io/cluster/my-cluster" = "shared"
  }
}

Custom mode (explicit subnet_map) with EKS tags:

module "network" {
  subnet_map = {
    "public-subnet" = {
      # ... config
      tags = {
        "kubernetes.io/role/elb" = "1"
        "kubernetes.io/cluster/my-cluster" = "shared"
      }
    }
  }
}

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

@vijay-stephen vijay-stephen merged commit 1bc92bb into main Nov 7, 2025
4 checks passed
@vijay-stephen vijay-stephen deleted the feature/update-custom-tags branch November 7, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants