feat(core): changes condition script for passed by and coming in clauses #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VipulSha99
force-pushed
the
GH-9-rebase
branch
from
139a718 to
92fbdf8
Compare
Collaborator
|
better description |
akshatdubeysf
requested changes
Nov 6, 2025
|
|
||
| @Output() | ||
| eventRemoved = new EventEmitter<unknown>(); | ||
| nodeRemoved = new EventEmitter<unknown>(); |
| if (nodeWithInput.node.state.get('email')) { | ||
| (value as AllowedValuesMap).body = ( | ||
| (value as AllowedValuesMap).body as string | ||
| ).replace(/\\"/g, '"'); |
| display: inline-block; | ||
| overflow: hidden; | ||
| max-width: 45%; | ||
| max-width: 15rem; |
Collaborator
There was a problem hiding this comment.
why a hard coded width? and why can't you override this in the target project
| [disabled]="!emailInput.subject || !emailInput.body" | ||
| > | ||
| {{ localizedStringKeys.SetLbl | localization }} | ||
| {{ setLbl }} |
| */ | ||
| element.node.elements.splice(-NUMBER.TWO, NUMBER.TWO); | ||
| // element.inputs[1].prefix = ''; | ||
| //this.enableActionIcon = false; |
| formatter: <S extends RecordOfAnyType>(state: State<S>) => { | ||
| if (typeof state.get('value') === 'object') { | ||
| return `'${JSON.stringify(state.get('value'))}'`; | ||
| switch (state.get('valueInputType')) { |
Collaborator
There was a problem hiding this comment.
looks like project specific implementation
| } | ||
|
|
||
| private intervalBodyPrepare(state: State<RecordOfAnyType>) { | ||
| if ( |
Collaborator
There was a problem hiding this comment.
move this out to a separate parser service or utility
| const tmp = params[key]; | ||
| if (isFormattedParam(tmp)) { | ||
| return `${p}\njson.prop("${key}", ${tmp.formatter(state)});`; | ||
| return `${p}\njson["${key}"] = ${tmp.formatter(state)};`; |
Collaborator
There was a problem hiding this comment.
Undo this, should not return stringified json from for object type variable
| import {InputTypes} from '../../../enum'; | ||
| import {RecordOfAnyType} from '../../../types'; | ||
|
|
||
| export class CriteriaInput extends WorkflowPrompt { |
Collaborator
There was a problem hiding this comment.
looks project specific?
| import {InputTypes} from '../../../enum'; | ||
| import {RecordOfAnyType} from '../../../types'; | ||
|
|
||
| export class StepperInput extends WorkflowPrompt { |
Collaborator
There was a problem hiding this comment.
what is a stepper input? explain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
changes condition script for passed by and coming in clauses
Fixes # (PRJ-7375)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: