Skip to content

Conversation

xhargh
Copy link
Contributor

@xhargh xhargh commented Mar 6, 2025

I noticed that a detached HEAD wasn't shown properly. Here is my try to fix it.

@love-linger
Copy link
Collaborator

  • First, I do not understand why HEAD and tags are always filtered in git log command
  • Second, I have not notice the difference behaviour between this PR and develop branch

@love-linger
Copy link
Collaborator

I noticed that a detached HEAD wasn't shown properly

image

@xhargh
Copy link
Contributor Author

xhargh commented Mar 7, 2025

I was not clear enough, my change fixes when we have a HEAD detached from something, like this:

image

which was shown like this before:

image

@love-linger
Copy link
Collaborator

I see. Then you should only add it to the default options if no filter is specified, such as:
image

@love-linger
Copy link
Collaborator

By the way, without this PR, you can find it by enable --reflogs
image

@xhargh xhargh force-pushed the detached-head-fix branch from cb6a4e9 to 264a486 Compare March 7, 2025 08:06
@xhargh
Copy link
Contributor Author

xhargh commented Mar 7, 2025

I think your version with adding HEAD if there are no filters is better.

I know about the reflog option, that is how I've even found the HEAD earlier. But in the reflog, there are other things that are not always of interest

@love-linger love-linger merged commit 89f655c into sourcegit-scm:develop Mar 7, 2025
13 checks passed
@love-linger love-linger self-assigned this Mar 7, 2025
@love-linger love-linger added the enhancement New feature or request label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants