-
Notifications
You must be signed in to change notification settings - Fork 308
fix: improve font string processing in SetFonts method #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I suggest you to move your code into sourcegit/src/ViewModels/Preferences.cs Lines 617 to 644 in e3cc987
|
|
If _sourcegit_20250313150319.mp4 |
|
If we do not remove the whitespace char at the end of a font name, Try |
|
I'll merge this PR first, and add some modifications. |
|
Line 453 in 03681ae
my code trimmed every font |
- Remove `SourceGit.ViewModels.Preference.FixFontFamilyName` (it is not necessary any more) - Use `string.Join` instead of `StringBuilder` to make the logic more clear Signed-off-by: leo <[email protected]>
Fixed the crash when the font is
,SomeFont.Situation encountered:
When I added
Noto Color Emoji, I wrote it at the beginning of the default font. In the TextBox, it wasNoto Color Emoji, HarmonyOS Sans SC. Then I found that the digital font became emoji, so I deleted the content before,and the whole app crashed.