Refactor: Optimize the WorkingCopy.IsChanged() method #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* There's no need to populate a Dictionary just to diff the the "old" and "cur" Lists of Changes. * If the two lists are of equal length and no change has occurred, we can assume that they are also reported in equal sort-order (by git-status). * Thus, we only need to compare the two items at each successive index.
goran-w
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to populate a
Dictionaryjust to diff theoldandcurLists of Changes (in the equal list-length case).If there has been no changes in the working-copy between the two calls to
QueryLocalChanges, we can assume that the items in the two lists are reported (bygit-status) in equal sort-order. And consequently, if thePathvalue DOES differ between two items at equal index in the two equal-length lists, we can directly conclude that some change has occurred between these two calls.Thus, we only need to loop through the successive list-indices (of the two equal-length lists), comparing the
Path,IndexandWorkTreevalues of theoandcitems at each such index.Loosely related to PR #1401 (where this refacoring was included but not merged).