Repo-search: apply filter also on Repos under matching Group-name #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name Group and Repo nodes are now name-filtered the same way, while still recursing into Groups with matching sub-Nodes. This is more intuitive and consistent with other filters in SourceGit. It makes filtering more effective, instead of favoring Group-matches over Item-matches. Addresses part of the discussion in issue sourcegit-scm#1454.
|
It was concluded in #1454 that this PR is not necessarily an improvement... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of the discussion in issue #1454.
Group and Repo nodes are now name-filtered the same way, while still recursing into Groups with matching sub-Nodes.
It makes filtering more effective, instead of favoring Group-matches over Item-matches.