refactor: auto dispatch notifications to UI thread in Launcher
#1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBaulch
force-pushed
the
autodispatch
branch
from
2fe9ac2 to
bb43574
Compare
NathanBaulch
changed the title
LauncherLauncher
love-linger
reviewed
Jul 2, 2025
NathanBaulch
force-pushed
the
autodispatch
branch
from
bb43574 to
452c7fe
Compare
love-linger
reviewed
Jul 2, 2025
love-linger
reviewed
Jul 2, 2025
NathanBaulch
force-pushed
the
autodispatch
branch
from
452c7fe to
e2036a1
Compare
love-linger
added a commit
that referenced
this pull request
Jul 2, 2025
- Remove unnecessary `CallUIThread` in `ViewModels.Clone` - Code style Signed-off-by: leo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of my work on #1439 I'd like to remove any UI concerns from the
SourceGit.Commandsnamespace.I'm no Avalonia expert but it seems simple enough to detect the wrong thread in
Launcherwhen processing notifications and dispatch to the UI thread as needed.The only outstanding question is whether to use
UIThread.PostorUIThread.Invokeas the existing code used a mixture of both.