feature: async #1492
Merged
feature: async #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBaulch
force-pushed
the
feature/async
branch
from
3ec92cc to
079ba14
Compare
|
This PR will not be merged until version |
|
I think the function name
|
|
Please do not create anthor PR until reviewing complete in |
|
Can I continue working in the |
love-linger
pushed a commit
that referenced
this pull request
Jul 3, 2025
* Async command methods * Async `Task.Run` where possible * Remove redundant `Task.Run` in `Sure` methods * Remove leftover braces and reformat * Async event handlers as needed
love-linger
pushed a commit
that referenced
this pull request
Jul 3, 2025
* Async command methods * Async `Task.Run` where possible * Remove redundant `Task.Run` in `Sure` methods * Remove leftover braces and reformat * Async event handlers as needed
love-linger
added a commit
that referenced
this pull request
Jul 3, 2025
- Remove all synchronous method in commands - `Command.ReadToEndAsync` now is protected method - Rename `ResultAsync` to `GetResultAsync` - Call `ConfigureAwait(false)` when there's no context Signed-off-by: leo <[email protected]>
|
I've decided to directly merge the |
|
Sure, I'll play with it tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in the async/await refactoring discussed in #1439. I was planning to submit all the work in a single PR but it's a wide reaching change that would be very time consuming to code review. Better to make the async transition in a few more manageable steps.