-
Notifications
You must be signed in to change notification settings - Fork 288
enhance: respect git config merge.ff
#1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds another configuration possibility for the default merge mode to the already existing per branch git configuration `branch.<name>.mergeoptions` (sourcegit-scm#540) and the per repo preference "Preferred Merge Mode" (sourcegit-scm#1156). Defined values: - `false`: do no fast-forward merge - `only`: do only a fast-forward merge This is configurable by for example `git config set --global merge.ff <value>` for a global (meaning the current user) configuration. The priority between these configurations/preferences is: - git configuration `branch.<name>.mergeoptions` (sourcegit-scm#540) - git configuration `merge.ff` - preference "Preferred Merge Mode" (sourcegit-scm#1156)
@love-linger In addition to adding this feature I have done a few refactorings regarding |
I think the I'll merge this first and modify it myself. |
- remove unused namespace using - prefer to use repository's configuration than the global `merge.ff` Signed-off-by: leo <[email protected]>
After changing the priority of the preferences/configurations for the merge mode in sourcegit-scm#1495, the git configuration `merge.ff` was ignored. The reason is, that `GetSettingsPreferredMergeMode()` does not return `null` in the default case. This is now fixed.
Okay!
There was a little problem so |
I just realized that when the user selects the Moreover, the description of the |
You are right, @love-linger. Your corresponding commit is d3d1377. |
This adds another configuration possibility for the default merge mode to the already existing per branch git configuration
branch.<name>.mergeoptions
(#540) and the per repo preference "Preferred Merge Mode" (#1156).Defined values:
false
: do no fast-forward mergeonly
: do only a fast-forward mergeThis is configurable by for example
git config set --global merge.ff <value>
for a global (meaning the current user) configuration.The priority between these configurations/preferences is:
branch.<name>.mergeoptions
([feature] default settings for merge options should be taken from .gitconfig #540)merge.ff