Skip to content

fix: do NOT reuse CommitDetail across commit #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: do NOT reuse CommitDetail across commit #1503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions src/ViewModels/Histories.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,16 +150,9 @@ public void NavigateTo(string commitSHA)

if (commit != null)
{
if (_detailContext is CommitDetail detail)
{
detail.Commit = commit;
}
else
{
var commitDetail = new CommitDetail(_repo, true);
commitDetail.Commit = commit;
DetailContext = commitDetail;
}
var commitDetail = new CommitDetail(_repo, true);
commitDetail.Commit = commit;
DetailContext = commitDetail;
}
else
{
Expand All @@ -183,16 +176,9 @@ public void Select(IList commits)
AutoSelectedCommit = commit;
NavigationId = _navigationId + 1;

if (_detailContext is CommitDetail detail)
{
detail.Commit = commit;
}
else
{
var commitDetail = new CommitDetail(_repo, true);
commitDetail.Commit = commit;
DetailContext = commitDetail;
}
var commitDetail = new CommitDetail(_repo, true);
commitDetail.Commit = commit;
DetailContext = commitDetail;
}
else if (commits.Count == 2)
{
Expand Down