Skip to content

refactor: remove anonymous function in ShowWindow #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor: remove anonymous function in ShowWindow #1511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions src/App.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,24 +108,9 @@ public static void LogException(Exception ex)
#region Utility Functions
public static void ShowWindow(object data, bool showAsDialog)
{
var impl = (Views.ChromelessWindow target, bool isDialog) =>
{
if (Current?.ApplicationLifetime is IClassicDesktopStyleApplicationLifetime { MainWindow: { } owner })
{
if (isDialog)
target.ShowDialog(owner);
else
target.Show(owner);
}
else
{
target.Show();
}
};

if (data is Views.ChromelessWindow window)
{
impl(window, showAsDialog);
Show(window, showAsDialog);
return;
}

Expand All @@ -142,7 +127,22 @@ public static void ShowWindow(object data, bool showAsDialog)
if (window != null)
{
window.DataContext = data;
impl(window, showAsDialog);
Show(window, showAsDialog);
}
}

private static void Show(Views.ChromelessWindow target, bool showAsDialog)
{
if (Current?.ApplicationLifetime is IClassicDesktopStyleApplicationLifetime { MainWindow: { } owner })
{
if (showAsDialog)
target.ShowDialog(owner);
else
target.Show(owner);
}
else
{
target.Show();
}
}

Expand Down