Skip to content

fix: Open Terminal on Welcome Page crashed (Windows) #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

fix: Open Terminal on Welcome Page crashed (Windows) #1740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/Native/Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,19 +203,23 @@ public void OpenBrowser(string url)

public void OpenTerminal(string workdir)
{
if (!File.Exists(OS.ShellOrTerminal))
var home = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);
var cwd = string.IsNullOrEmpty(workdir) ? home : workdir;
var terminal = OS.ShellOrTerminal;

if (!File.Exists(terminal))
{
App.RaiseException(workdir, "Terminal is not specified! Please confirm that the correct shell/terminal has been configured.");
return;
}

var startInfo = new ProcessStartInfo();
startInfo.WorkingDirectory = workdir;
startInfo.FileName = OS.ShellOrTerminal;
startInfo.WorkingDirectory = cwd;
startInfo.FileName = terminal;

// Directly launching `Windows Terminal` need to specify the `-d` parameter
if (OS.ShellOrTerminal.EndsWith("wt.exe", StringComparison.OrdinalIgnoreCase))
startInfo.Arguments = $"-d {workdir.Quoted()}";
if (terminal.EndsWith("wt.exe", StringComparison.OrdinalIgnoreCase))
startInfo.Arguments = $"-d {cwd.Quoted()}";

Process.Start(startInfo);
}
Expand Down
Loading