-
Notifications
You must be signed in to change notification settings - Fork 286
Improve image diff #1797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve image diff #1797
Conversation
Similar to the BLEND image-diff mode, but instead blends towards total DIFFERENCE at 50%. (This way, we can look at the difference in the middle, and slide towards OLD or NEW to view their respective contributions to the diff.)
Maybe add screenshots to show the new mode? |
First off, here are the modifications I made to the To show the DIFFERENCE mode, I'm borrowing the following images from https://www.textcompare.org/blog/how-to-compare-images/ : ![]() Here's how that looks at 50% (full difference) in the new By moving the slider slightly to the left / right, we start to blend in the corresponding OLD / NEW image, to show the difference-spots in context (while moving it all the way to the left / right would show only the original corresponding image) : NOTE: This new DIFFERENCE comparison mode uses the |
I really like the new |
Or keep SIDE-BY-SIDE, BLEND, and DIFFERENCE, and remove SWIPE. Because I don't think SWIPE can achieve a good comparison effect. |
I think all these modes have their strengths - it all depends on the nature of the two images we're trying to compare, sometimes the differences are very subtle but at other times the two images can be almost completely different. Sometimes we already know where the differences lies, like a color-change of an object, and then Blend and Swipe are both good (also common and popular) ways for comparing before-and-after. If there is text in the image, the Swipe mode can make it easier (than the Blend mode) to check for wording differences. I'm coming from the Plastic SCM version control system, where their built-in image-diff tool has 4 quite similar modes to the ones we're discussing (though their Differences mode instead uses an "inverted XOR" method) :
See them in action here: |
* Removed decimals from % values shown for ImageBlendSlider * Moved OLD text at ImageBlendSlider, for symmetry and non-jumpiness * Added ticks on ImageBlendSlider, at 0%, 50% and 100% * Added new image-diff mode DIFFERENCE Similar to the BLEND image-diff mode, but instead blends towards total DIFFERENCE at 50%. (This way, we can look at the difference in the middle, and slide towards OLD or NEW to view their respective contributions to the diff.) * Selected image-diff mode is now persistent
ImageBlendSlider
(visual noise, not needed).ImageBlendSlider
, for symmetry and to remove "jumping" UI.ImageBlendSlider
, at 0%, 50% and 100%, to make it easier to find the 50% mark again.