Skip to content

Conversation

filipeRmlh
Copy link
Contributor

No description provided.

@love-linger love-linger self-assigned this Sep 1, 2024
@love-linger
Copy link
Collaborator

love-linger commented Sep 1, 2024

I'm very sorry. Due to the following reasons, this PR will not be merged into the project:

  • Using 4000 for Models.Diff.MaxDiffUnified is not a good idea to achieve this goal. Maybe we can read the revision file content then combine the diff with it?
  • When the file contains a lot of lines, it is hard to find the next diff chunk since we do not provide buttons to goto next or prev diff content or just a mini-map in scrollbar helping user locate it.
  • If the file contains too many lines, I am worried about the actual running performance of this feature.
  • Currently, this app supports open diff with external tools,and it is very convenient to do this job. Most professional comparison tools display the entire file content and the changed parts by default. I think this requirement should be handled by external tools.

@love-linger love-linger closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants