Skip to content

Conversation

hannesbraun
Copy link
Contributor

I think automatically selecting and showing the next change after staging or unstaging is more useful than having nothing selected.

While I think that this is already an improvement, I wasn't able to keep the focus on the (new) selected element so that I could use the arrow keys to further navigate in the changes after (un)staging. I'm still new to Avalonia and might be overlooking something. Maybe you know how to fix this... 😅

@love-linger
Copy link
Collaborator

Actually, I don't like this feature.

  • As you said, it's hard to auto focus the next change since the background data (local changes) will be re-calculated after file system watcher detects some file in repository changed.
  • I don't really want to add too many predictive user actions to this project. When people stage/unstage local changes one-by-one instead of all, which is the next they want to check?

@love-linger
Copy link
Collaborator

I've pushed another implementation for this feature.

@hannesbraun
Copy link
Contributor Author

I've pushed another implementation for this feature.

Thanks!

  • I don't really want to add too many predictive user actions to this project. When people stage/unstage local changes one-by-one instead of all, which is the next they want to check?

Hmm, I wouldn't say it's predictive. It just allows me to further navigate in the changes after a (un)stage with the keyboard. The use case would be (at least for me) if I have a lot of changes and I want to navigate through them with the arrow keys and stage just the ones I want. If the changes are small or very similar this would also allow me to double check the diff just very quick again (by staging each file one by one) before I author the commit. All of this would also be possible using the mouse, however that takes more time. But of course, this use case might not be relevant for anyone. I just thought I'd share it. So I understand if you don't want to add it. It's a pretty good git client already :)

And sorry for my somewhat delayed answer.

@hannesbraun hannesbraun deleted the select-next-change branch September 12, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants