refactor: terminal launch on macOS without temporary AppleScript #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
love-linger
added a commit
that referenced
this pull request
Sep 10, 2024
* remove Visual Studio ENC0004 warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the method for opening the terminal on macOS by removing the use of temporary AppleScript files. The previous implementation involved generating, executing, and then deleting a temporary AppleScript file. This has been replaced with a more efficient and cleaner approach using the
open -a {terminal} "{dir}"command to directly launch the desired terminal and open the target directory.Environment.GetFolderPath(Environment.SpecialFolder.UserProfile)instead of~because there is no tilde expansion\"{dir}\", so the linedir = dir.Replace(" ", "\\ ");is removed.