Skip to content

Conversation

aikawayataro
Copy link
Contributor

This also includes a small error message correction, a fix for crash when opening terminal on the Welcome page on Linux, and finally will add support for spawning host's terminal form flatpak.
There's no support to use host's merge tools, as changes will collide with #473 and I still need some time to implement it properly but it is on the way

@love-linger
Copy link
Collaborator

After reading your PR, I have some understanding of how does flatpak work. To tell the truth, I start to dislike flatpak - it even requires explicitly calling flatpak-spawn when creating an external subprocess...

@aikawayataro
Copy link
Contributor Author

aikawayataro commented Sep 16, 2024

Well, I dislike Flatpak too 😁. People just keep asking for it
I don't like flatpaks mostly because of their size. They are easy to deploy and install, but there are some major drawbacks

even requires explicitly calling flatpak-spawn when creating an external subprocess...

only if you want to spawn process inside a host, like a terminal or a merge tool, git is fine inside container.

To summarize, I think software like development tools are simply not ready for flatpak. The problems I faced with gpg, it sends xauth data to gpg-agent (well nobody thought gpg will connect to "remote" gpg-agent) and gpg-agent fails to use flatpak's xauth to create a pinentry window with a cryptic error message. It is fixable, but serves a good example of how things are broken inside flatpak.

4deac98 alone is still useful though. Can you cherry-pick it or do I need to extract it to a new pull request?

@love-linger
Copy link
Collaborator

4deac98 alone is still useful though. Can you cherry-pick it or do I need to extract it to a new pull request?

you can create a new pr for that commit, i'll merge it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants