Adding missing pt_BR translation keys #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougcunha
reviewed
Nov 8, 2024
| <x:String x:Key="Text.Stash.Message.Placeholder" xml:space="preserve">Opcional. Nome deste stash</x:String> | ||
| <x:String x:Key="Text.Stash.Message" xml:space="preserve">Mensagem:</x:String> | ||
| <x:String x:Key="Text.Stash.OnlyStagedChanges" xml:space="preserve">Apenas mudanças em stage</x:String> | ||
| <x:String x:Key="Text.Stash.TipForSelectedFiles" xml:space="preserve">Tanto mudanças em stage e fora de stage dos arquivos selecionados serão enviadas para stash!!!</x:String> |
There was a problem hiding this comment.
The translation is generally excellent. I would suggest removing two of the exclamation marks, leaving only one. In formal Portuguese, using multiple exclamation marks is considered incorrect.
There was a problem hiding this comment.
Hey @dougcunha thanks for the comment! I was in between removing it or not. Since the key Text.Stash.TipForSelectedFiles in the en_US file included these three exclamation marks, I suppose it was the developer's intention to deliver emphasis or attention and opted for keeping the same way.
I have no strong opinions on that, I'm happy to change to a single one if you think it would be better. 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just adding some missing pt_BR translation keys, as this is my mother language.
This change makes the file fully in sync with the en_US localization file.
A comment was also added aiming to bring standardization to the terms, feel free to remove it.