-
Notifications
You must be signed in to change notification settings - Fork 290
Add children list to the commit base info view #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Useful for navigation between the commits.
FWIW to me it would make sense to change parent and children lists from |
To be honest, I don't really like this feature - especially the design of
I also don't agree with this modification. Relevant, if necessary, I will provide a custom text block control that used to display |
You don't find this feature useful in principle, or you would prefer a different implementation? An alternative would be to search for the commit's children when it is being displayed. Or maybe you have some other idea? |
This reverts commit 7ba35e1.
I've reverted the previous attempt and made another one. This time children are fetched asynchronously for a specific commit while the view is being rendered. If I understood your feedback correctly, that should be more in line with your approach. Now, it is possible that I didn't understand your feedback correctly. If that is the case, I would appreciate if you could explain what kind of implementation for this feature you would like to see. Or close the PR if you don't regard this functionality as a desirable feature. Either way I hope I didn't waste too much of your time unnecessarily, and I am really sorry if I did. |
Useful for navigation between the commits.
Nice job. It's better now. |
* add translations for zh_CN and zh_TW * hide `CHILDREN` line if it is empty Signed-off-by: leo <[email protected]>
I'm sorry. I will revert this PR due to the performance of |
* the `Commands.QueryCommitChildren` takes too much time when executes in a large repo Signed-off-by: leo <[email protected]>
I see. It was much faster with repos I tried, so thank you for the pointer at a better test. I will look into this next weekend. |
Useful for navigation between the commits.
The implementation is suboptimal. It would probably make more sense to search for children when the view is displayed, but that would require much more substantial changes as currently commit list is not available in the view.
That said, in my testing this implementation appears to perform acceptably.