Skip to content

Conversation

aikawayataro
Copy link
Contributor

@aikawayataro aikawayataro commented Nov 12, 2024

Refactor rpm's Requires: to depend on SO instead of package

Add *.spec and control to .gitattributes and .editorconfig (without it vscode will change EOL to CRLF every time file is touched, a bit inconvenient when testing locally)

Remove redundant VERSION and RUNTIME variable checks in CI build scripts as set -u was introduced in #498

Tested with Fedora 41 (x86_64 and arm64), openSUSE 15.6 (x86_64 and arm64)

Closes #686

Back in 211c263, I changed the dependencies to depend on package instead of shared object. This worked well, but introduced some problems for distros other than Fedora (81f76f0). I did this because of problems with the arm64 package, but now I think `__isa_bits` is a reasonable workaround.
@love-linger love-linger self-assigned this Nov 12, 2024
@love-linger love-linger added the bug Something isn't working label Nov 12, 2024
@love-linger love-linger linked an issue Nov 12, 2024 that may be closed by this pull request
@love-linger love-linger merged commit 146f383 into sourcegit-scm:develop Nov 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation error from rpm package

2 participants