fix: commit histories double click error #701
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor 'if-else' snippet to 'ifs' with early returns
- When a commit was selected and you double tapped an empty section of the histories ListBox, the last selected commit was checkout. - Using the 'TappedEventArgs' properties, and validating the name of the tapped section (PART_ContentPresenter) we can avoid this.
albertodlc
changed the title
|
I've pushed my implementation for this issue. See commit 4835c3f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error
When a commit was selected (single click without checkout) and the user double tapped in an empty part of the histories ListBox
The Checkout message was displayed for the last selected commit.
Fix
It shouldn't execute that action unless the user double tap on a commit. I validated the name of the pressed UI element and ignore the empty part of the checkbox.