Skip to content

Conversation

wl2776
Copy link
Contributor

@wl2776 wl2776 commented Dec 30, 2024

On MacOS git can be installed in /usr/local/ or with HomeBrew.

Add support for these paths.

@love-linger love-linger self-assigned this Dec 31, 2024
@love-linger love-linger added the enhancement New feature or request label Dec 31, 2024
@love-linger love-linger merged commit addc756 into sourcegit-scm:develop Dec 31, 2024
13 checks passed
@wl2776 wl2776 deleted the feature/find-git-macos branch January 2, 2025 12:57
@TomaSajt
Copy link

TomaSajt commented Jan 6, 2025

By the way, why are we not using the PATH env-var, like done for Linux?
See #72

@love-linger
Copy link
Collaborator

By the way, why are we not using the PATH env-var, like done for Linux? See #72

On macOS, GUI app cannot access the full PATH environment.
#566
#546
#545
#539
#507

@wl2776
Copy link
Contributor Author

wl2776 commented Jan 6, 2025

Full list of global paths is stored in file /etc/paths and files under /etc/paths.d/

https://stackoverflow.com/a/38670834/704329

@love-linger
Copy link
Collaborator

love-linger commented Jan 7, 2025

Full list of global paths is stored in file /etc/paths and files under /etc/paths.d/

https://stackoverflow.com/a/38670834/704329

For example: you can see that the /opt/homebrew/bin is not list in /etc/paths, and /etc/paths.d only contains dotnet envs

400602226-16bbd19f-78af-4acf-8a5c-a8e398e04dae

@wl2776
Copy link
Contributor Author

wl2776 commented Jan 7, 2025

Full list of global paths is stored in file /etc/paths and files under /etc/paths.d/
https://stackoverflow.com/a/38670834/704329

For example: you can see that the /opt/homebrew/bin is not list in /etc/paths, and /etc/paths.d only contains dotnet envs

Plus, it seems, these files might be shell scripts and their parsing in order to retrieve some peculiar custom paths could be cumbersome.

This proves that existing 4 variants are enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants