Skip to content

Conversation

wl2776
Copy link
Contributor

@wl2776 wl2776 commented Jan 12, 2025

Rename methods whose names start with TryLaunched... to TryLaunch....
The word "Try" implies the question "what to do?" and therefore should be followed with a verb. Example: try to launch, try to search. "Launched" is not a verb, it is adjective. "To" is omitted for brevity.

Rename "Preference" -> "Preferences". This word is used in plural everywhere (Settings, Preferences, Parameters, Parameters).

image

Unfortunately, the word "Preference" is used everywhere in the project, which caused a fleshy commit.

@love-linger love-linger self-assigned this Jan 13, 2025
@love-linger love-linger added the typo Fix typos label Jan 13, 2025
@love-linger love-linger merged commit 6e5626f into sourcegit-scm:develop Jan 13, 2025
13 checks passed
@wl2776 wl2776 deleted the fix/grammar branch January 13, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typo Fix typos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants