fix: adjust SHA regex pattern to min 6 chars #944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjust the SHA regex pattern to match commit hashes with a minimum length of 6 characters instead of 10.
|
It's because that some issue tracker system also uses 6-8 hex characters. |
|
As far as I know, Gitee use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum length of a Git commit ID can be 4 hexadecimal characters. Considering that
Diff.csuses a 6-40 character string for validation, the check for commit IDs in the commit message has been shortened to 6 characters. For example, GitHub considers a 7-character string as a valid commit ID.