Skip to content

Conversation

gadfly3173
Copy link
Contributor

@gadfly3173 gadfly3173 commented Feb 1, 2025

  • Add SHA property to the Dot class and assign commit SHA to anchor instances in the CommitGraph model.
  • Add constructor to initialize commit relation tracking with repository path and commit hash, enabling querying and displaying related refs while managing loading state.
  • Add pointer interaction handlers to the CommitGraph class for displaying commit details on click, updating cursor on hover, and resetting cursor on exit.

Only tested on Windows 10.

Image

- Add SHA property to the Dot class and assign commit SHA to anchor instances in the CommitGraph model.
- Add constructor to initialize commit relation tracking with repository path and commit hash, enabling querying and displaying related refs while managing loading state.
- Add pointer interaction handlers to the `CommitGraph` class for displaying commit details on click, updating cursor on hover, and resetting cursor on exit.
@love-linger
Copy link
Collaborator

I think the current implementation is good enough and there is no need to include this feature in the commit graph.

@gadfly3173
Copy link
Contributor Author

I think the current implementation is good enough and there is no need to include this feature in the commit graph.

This idea was proposed by #940 and has two thumbs up. It might be better to comment in the issue.

@love-linger love-linger self-assigned this Feb 10, 2025
@love-linger love-linger added the not-planned It's not planned in the future label Feb 10, 2025
@gadfly3173 gadfly3173 deleted the feat/graph-tip branch May 13, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-planned It's not planned in the future

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants