-
Notifications
You must be signed in to change notification settings - Fork 30
Re-enable a test in SmartApplyTests.cs #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
617d396
Enhance logging in ApplyLastSuggestionFor & add a timeout
mkondratek 3fbda90
Wait for Attached instead of Visible button
mkondratek de9291e
more debug
mkondratek 5af60be
fixes
mkondratek 18b0f75
fixes
mkondratek b72525d
fixes
mkondratek e9824b5
remove logging
mkondratek 17d7175
debug
mkondratek 26e789b
debug
mkondratek 794fe45
ddebug
mkondratek b883a7d
fixes
mkondratek 8bc3194
fixes
mkondratek 1b8b5bd
fixes
mkondratek e75c4b7
debug
mkondratek b3f2d26
fixes
mkondratek cabd9d5
add a dummy test
mkondratek 4fb8ebb
add a comment
mkondratek 60112a8
fixes
mkondratek 93a017b
fixes
mkondratek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,8 @@ public Manager2() { } | |
|
|
||
| public void Print() | ||
| { | ||
| Console.WriteLine("Hello, World!"); | ||
| var mesage = "Hello, World!"; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The fix is to do something more obviously incorrect here. Before, sometimes Cody suggested no changes (no code snippets). Now we do an explicit typo. Still not ideal - ideally, we have recordings and the test runs are deterministic. |
||
| Console.WriteLine(mesage); | ||
|
|
||
|
|
||
| Console.WriteLine("Bye, World!"); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn’t expecting this to be the fix, nor was it the outcome I aimed for, but it does solve the issue.